From 5ac917835e8f350fe28b79fbf43d203afd2f0ca2 Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Sun, 18 Jan 2026 20:54:02 -1000 Subject: [PATCH] Revert "cleanup" This reverts commit bac836d2a740e565f9c6b4cc01fb53f4a02e122e. --- esphome/components/logger/logger_esp8266.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/esphome/components/logger/logger_esp8266.cpp b/esphome/components/logger/logger_esp8266.cpp index 09ae6b5731..e10ff45519 100644 --- a/esphome/components/logger/logger_esp8266.cpp +++ b/esphome/components/logger/logger_esp8266.cpp @@ -3,11 +3,11 @@ #include "esphome/core/log.h" // Direct UART register access for optimized write path -// Arduino's Serial.write() (uart.cpp lines 545-548) has significant overhead: -// - PROGMEM read for every character (unnecessary for RAM buffers) -// - optimistic_yield(10000) after every character (scheduler overhead) -// - Per-character FIFO checks via uart_do_write_char() (line 513) -// Direct register writes with batching eliminate ~300 function calls per 100-byte message. +// Arduino's Serial.write() has significant overhead: +// - pgm_read_byte() for every character (unnecessary for RAM buffers) +// - optimistic_yield() after every character (massive scheduler overhead) +// - Per-character FIFO checks (could batch) +// Direct register writes with batching are 10-50x faster for CPU-side work. #include // USF, USS, USTXC register macros namespace esphome::logger {