mirror/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-02-24 20:35:30 -07:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Add fast_select diagnostic counters logged every 10000 loops"

Browse Source 
This reverts commit 29ffeeeb19.
This commit is contained in:
J. Nick Koston
2026-02-23 22:22:26 -06:00
parent 29ffeeeb19
commit 07014b09ae
2 changed files with 1 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
esphome/core/application.cpp
View File

@@ -647,7 +647,6 @@ void Application::yield_with_select_(uint32_t delay_ms) {
// This scan preserves select() semantics: return immediately when any fd is ready.
for (int fd : this->socket_fds_) {
if (esphome_lwip_socket_has_data(fd)) {
this->fast_select_skip_count_++;
yield();
return;
}
@@ -657,20 +656,7 @@ void Application::yield_with_select_(uint32_t delay_ms) {
// Woken by: callback wrapper (socket data arrives), wake_loop_threadsafe() (other tasks), or timeout.
// Without USE_WAKE_LOOP_THREADSAFE, only hooked socket callbacks wake the task —
// background tasks won't call wake, so this degrades to a pure timeout (same as old select path).
uint32_t notified = ulTaskNotifyTake(pdTRUE, pdMS_TO_TICKS(delay_ms));
if (notified > 0) {
this->fast_select_woken_count_++;
} else {
this->fast_select_timeout_count_++;
}
if (++this->fast_select_total_count_ >= 10000) {
ESP_LOGD(TAG, "fast_select: woken=%" PRIu32 " timeout=%" PRIu32 " skip=%" PRIu32 " (of 10000 loops)",
this->fast_select_woken_count_, this->fast_select_timeout_count_, this->fast_select_skip_count_);
this->fast_select_total_count_ = 0;
this->fast_select_woken_count_ = 0;
this->fast_select_timeout_count_ = 0;
this->fast_select_skip_count_ = 0;
}
ulTaskNotifyTake(pdTRUE, pdMS_TO_TICKS(delay_ms));
#elif defined(USE_SOCKET_SELECT_SUPPORT)
// Non-ESP32 select() path (LibreTiny bk72xx/rtl87xx, host platform).

7
esphome/core/application.h
View File

@@ -592,13 +592,6 @@ class Application {
#if defined(USE_SOCKET_SELECT_SUPPORT) && !defined(USE_ESP32)
int max_fd_{-1}; // Highest file descriptor number for select()
#endif
#if defined(USE_SOCKET_SELECT_SUPPORT) && defined(USE_ESP32)
// Diagnostic counters for fast select sleep behavior (logged every 1000 loops)
uint32_t fast_select_total_count_{0};
uint32_t fast_select_woken_count_{0}; // Woken by notification (socket data or wake_loop_threadsafe)
uint32_t fast_select_timeout_count_{0}; // Slept full duration (no notification)
uint32_t fast_select_skip_count_{0}; // Skipped sleep (socket already had data)
#endif
// 2-byte members (grouped together for alignment)
uint16_t dump_config_at_{std::numeric_limits<uint16_t>::max()}; // Index into components_ for dump_config progress