mirror/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-03-01 02:14:19 -07:00
Code Issues Packages Projects Releases Wiki Activity

Rename call_loop() to call_loop_() for naming convention

Browse Source 
Non-virtual protected methods require trailing underscore
per clang-tidy readability-identifier-naming.
This commit is contained in:
J. Nick Koston
2026-02-18 22:47:27 -06:00
parent db8618e5fe
commit 168081c0f0
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
esphome/core/component.cpp
View File

@@ -204,7 +204,7 @@ bool Component::cancel_retry(uint32_t id) {
#pragma GCC diagnostic pop
}
void Component::call_loop() { this->loop(); }
void Component::call_loop_() { this->loop(); }
void Component::call_setup() { this->setup(); }
void Component::call_dump_config() {
this->dump_config();
@@ -255,11 +255,11 @@ void Component::call() {
case COMPONENT_STATE_SETUP:
// State setup: Call first loop and set state to loop
this->set_component_state_(COMPONENT_STATE_LOOP);
this->call_loop();
this->call_loop_();
break;
case COMPONENT_STATE_LOOP:
// State loop: Call loop
this->call_loop();
this->call_loop_();
break;
case COMPONENT_STATE_FAILED:
// State failed: Do nothing

2
esphome/core/component.h
View File

@@ -286,7 +286,7 @@ class Component {
protected:
friend class Application;
void call_loop();
void call_loop_();
virtual void call_setup();
virtual void call_dump_config();