mirror/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-02-20 16:35:37 -07:00
Code Issues Packages Projects Releases Wiki Activity

[wifi] Fix ESP8266 disconnect callback order to set error flag before notifying listeners

Browse Source
This commit is contained in:
J. Nick Koston
2026-01-13 08:14:46 -10:00
parent 714188cfd8
commit 39f77a3315
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
esphome/components/wifi/wifi_component_esp8266.cpp
View File

@@ -543,10 +543,12 @@ void WiFiComponent::wifi_event_callback(System_Event_t *event) {
}
s_sta_connected = false;
s_sta_connecting = false;
// Set error flag BEFORE notifying listeners so is_connected() returns
// correct state during listener callbacks (matches ESP-IDF behavior)
// IMPORTANT: Set error flag BEFORE notifying listeners.
// This ensures is_connected() returns false during listener callbacks,
// which is critical for proper reconnection logic (e.g., roaming).
global_wifi_component->error_from_callback_ = true;
#ifdef USE_WIFI_LISTENERS
// Notify listeners AFTER setting error flag so they see correct state
static constexpr uint8_t EMPTY_BSSID[6] = {};
for (auto *listener : global_wifi_component->connect_state_listeners_) {
listener->on_wifi_connect_state(StringRef(), EMPTY_BSSID);