mirror/esphome
1
0
Fork 0
mirror of https://github.com/esphome/esphome.git synced 2026-02-21 17:05:36 -07:00
Code Issues Packages Projects Releases Wiki Activity

Merge remote-tracking branch 'origin/parition_callbacks' into parition_callbacks

Browse Source
This commit is contained in:
J. Nick Koston
2025-11-09 23:20:01 -06:00
parent 0f136a888c 6feaa8dd13
commit f19bbbd1c5
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
esphome/core/helpers.h
View File

@@ -893,11 +893,12 @@ template<typename... Ts> class PartitionedCallbackManager<void(Ts...)> {
this->callbacks_ = make_unique<std::vector<std::function<void(Ts...)>>>();
}
// Add to first partition: append then swap into position
// Add to first partition: append then rotate into position
this->callbacks_->push_back(std::move(callback));
// Avoid potential underflow: rewrite comparison to not subtract from size()
if (*first_count + 1 < this->callbacks_->size()) {
std::swap((*this->callbacks_)[*first_count], (*this->callbacks_)[this->callbacks_->size() - 1]);
// Use std::rotate to maintain registration order in second partition
std::rotate(this->callbacks_->begin() + *first_count, this->callbacks_->end() - 1, this->callbacks_->end());
}
(*first_count)++;
}