scratch/esphome
1
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases Wiki Activity

[text] Avoid string copies in callbacks by passing const ref (#12504)

Browse Source
This commit is contained in:
J. Nick Koston
2025-12-17 10:00:19 -07:00
committed by GitHub
parent 94763ebdab
commit 42e061c9ae
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
esphome/components/text/text.cpp
View File

@@ -23,7 +23,7 @@ void Text::publish_state(const std::string &state) {
#endif
}
void Text::add_on_state_callback(std::function<void(std::string)> &&callback) {
void Text::add_on_state_callback(std::function<void(const std::string &)> &&callback) {
this->state_callback_.add(std::move(callback));
}

4
esphome/components/text/text.h
View File

@@ -31,7 +31,7 @@ class Text : public EntityBase {
/// Instantiate a TextCall object to modify this text component's state.
TextCall make_call() { return TextCall(this); }
void add_on_state_callback(std::function<void(std::string)> &&callback);
void add_on_state_callback(std::function<void(const std::string &)> &&callback);
protected:
friend class TextCall;
@@ -44,7 +44,7 @@ class Text : public EntityBase {
*/
virtual void control(const std::string &value) = 0;
CallbackManager<void(std::string)> state_callback_;
CallbackManager<void(const std::string &)> state_callback_;
};
} // namespace text